4XLab.NET : Forex Lab Community Server

Search Sort Posts:  Oldest to newest Newest to oldest

10-28-2007, 7:55 AM sandrov Joined on 10-19-2007 Posts 2 iEMA implementation LS., First of all I think this site is a brilliant initiative! I've downloaded the sourcecode and found a small implementation glitch in the EMA function at approx. line 387 (indicators.cs). When the tickcount equals periods: no calculation is done with the input value Val. In order to correct this the code should be like: If (tickcount == periods) {   emav += Val;   emav /= (periods+1); }   Cheers, Alexander    Report

12-20-2007, 11:50 AM JoeMama Joined on 06-07-2007 Posts 5 Re: iEMA implementation Is this a valid fix, can you post the whole function so I can see your change against the original    Report

03-02-2008, 9:03 AM sandrov Joined on 10-19-2007 Posts 2 Re: iEMA implementation   public void ReceiveTick(double Val)   {    if (tickcount < periods)     emav += Val;    if (tickcount ==periods) // added this line, otherwise the Val is disregarded     emav += Val;     emav /= periods;    if (tickcount > periods)     emav = (dampen*(Val-emav))+emav;    if (tickcount <= (periods+1) )    {       // avoid overflow by stopping use of tickcount     // when indicator is fully primed     tickcount++;    }   }    Report

04-12-2008, 8:38 PM asimon Joined on 03-07-2006 Posts 137 Re: iEMA implementation Do remember that C language syntax specifies that if { } are not added after an if condition, only one statement will be executed. It is one of the many reasons why we can have the The International Obfuscated C Code Contest each year. thus the corrected function should read as follows: public void ReceiveTick(double Val)   {    if (tickcount < periods)     emav += Val;    if (tickcount ==periods)     // we need opening curly braces here to include 2 statements     {                 emav += Val;   // added this line, otherwise the Val is disregarded          emav /= periods;     }     // curly braces are not needed here since only one statement is executed    if (tickcount > periods)     emav = (dampen*(Val-emav))+emav;    if (tickcount <= (periods+1) )    {       // avoid overflow by stopping use of tickcount     // when indicator is fully primed     tickcount++;    }   }    Report

4XLab.NET : For... » 4XLab.NET » Questions and A... » iEMA implementation

(please select) Forums Home |- Search Forums |- Active Topics |- Unanswered Posts User Options |- Sign In |- Join this community |- Forgot Password 4XLab.NET |- Introduction |- Tools Of The Trade |- Automated Trading Systems |- FX University |-- Forums |-- Classrooms |- 4XLab.NET Trading Systems Source Code |-- 4XLab.NET GUI Source Code |- Indicators |- Questions and Answers |- InvestorFLIX |- Articles Lectures |- Lesson Meeting Times |- Week 1 |- Week 2